Skip to content

Conversation

@Arusekk
Copy link
Contributor

@Arusekk Arusekk commented Feb 19, 2025

@jans23
Copy link
Member

jans23 commented Feb 19, 2025

Thank you for your persistence in fixing this issue. I'm not familar with the font variants. what is the "ext" within the new font you chose?

@Arusekk
Copy link
Contributor Author

Arusekk commented Feb 19, 2025

Honestly, I don't know. I just know it is the exact set of glyphs that contains the missing ę I referenced in the issue. On the website there are three checkboxes: basic latin script (ISO-8859-1 I presume, because it does contain some non-ASCII letters), the rest of latin script (non-basic) and one indian script. Since it was previously restricted to basic latin only, I assumed no non-latin-script translation is coming in the nearest future.

@jans23 jans23 requested a review from daringer February 20, 2025 08:19
@jans23
Copy link
Member

jans23 commented Feb 20, 2025

@daringer please have a look at the failed check.

@Arusekk
Copy link
Contributor Author

Arusekk commented Feb 27, 2025

The failed check looks like a transient network error. Maybe you can restart the job?

@daringer
Copy link
Contributor

daringer commented Feb 27, 2025

yes, this is a bug, this part of the CI should not run on external repositories - need to split the job into two and only activate one for external PRs.

Anyways: lgtm, tested locally, merging, thx @Arusekk

@daringer daringer merged commit ae28189 into Nitrokey:main Feb 27, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[cosmetic] Headline font missing Polish glyphs

3 participants